Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agenda and agendaupdate: add --details length #817

Closed
wants to merge 2 commits into from

Conversation

michaelmhoffman
Copy link
Collaborator

@michaelmhoffman michaelmhoffman commented Nov 17, 2024

Implements #791.

To eliminate the possibility of conflicts between length and end_date/end_time, this raises NotImplementedError if input is supplied with both of the fields.

In the future, the following would be better conflict resolution approaches:

  1. allow both end fields and length field long as they are consistent in each row
  2. conflict resolution by command-line option (e.g. prefer end fields or prefer length field)
  3. conflict resolution interactively

@dbarnett
Copy link
Collaborator

Closed without merging? Did you change your mind about this change?

@michaelmhoffman
Copy link
Collaborator Author

No, I thought I was just renaming master to main in my fork, and I guess this was a side effect. Argh.

@michaelmhoffman
Copy link
Collaborator Author

Reopening

@michaelmhoffman
Copy link
Collaborator Author

I may need to make a new pull request to actually reopen. Or can just merge if you're OK with it. Or you can.

@dbarnett
Copy link
Collaborator

Ah funny, because michaelmhoffman:master no longer exists…

If you can open a new PR that'll probably be easiest to follow. I would try to merge the it here but the button is gone and "reopen" is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants