Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upsert-d-param ExUnit error #341

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix upsert-d-param ExUnit error #341

merged 3 commits into from
Dec 19, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Dec 19, 2024

Description

Fixes the bug with ExUnits.

link

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@jankun4 jankun4 requested review from LGLO and AmbientTea December 19, 2024 10:32
Copy link
Contributor

@LGLO LGLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but indeed seems to fix the bug

@jankun4 jankun4 enabled auto-merge (squash) December 19, 2024 13:50
@jankun4 jankun4 disabled auto-merge December 19, 2024 14:03
@LGLO LGLO enabled auto-merge (squash) December 19, 2024 16:32
@LGLO LGLO merged commit de4ba1b into master Dec 19, 2024
13 of 14 checks passed
@LGLO LGLO deleted the fix-d-param-ex-units-bug branch December 19, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants