Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement idempotency for init-reserve-management #339

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Dec 19, 2024

Description

Do not try to build and submit any script initialization if there is a proof on the chain, that it has already been initialized.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@LGLO LGLO requested review from jankun4 and kpinter-iohk December 19, 2024 05:32
Copy link
Contributor

@kpinter-iohk kpinter-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic comments, otherwise LGTM

@LGLO LGLO enabled auto-merge (squash) December 19, 2024 16:46
@LGLO LGLO merged commit 0a6dfd1 into master Dec 19, 2024
13 of 14 checks passed
@LGLO LGLO deleted the ETCM-9040-idempotency branch December 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants