Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: ETCM-8949 use permissioned candidates offchain in wizard #315

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Dec 10, 2024

Description

Uses the Rust implementation of the upsert-permissioned-candidates operation instead of relying on the pc-contracts-cli in the wizard.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch 2 times, most recently from b3f0d79 to 7cc10d5 Compare December 10, 2024 12:45
@AmbientTea AmbientTea requested review from jankun4, LGLO and gilligan and removed request for jankun4 December 10, 2024 15:44
@AmbientTea AmbientTea force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch from 7cc10d5 to d323646 Compare December 10, 2024 15:56
@AmbientTea AmbientTea marked this pull request as ready for review December 10, 2024 15:57
@AmbientTea
Copy link
Contributor Author

Upsert-permissioned-cadndidates has a bug which needs to be fixed before this PR can be merged.

@AmbientTea AmbientTea force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch from d323646 to b6564f2 Compare December 11, 2024 08:26
@LGLO LGLO force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch 4 times, most recently from 06a66f5 to f76e54d Compare December 18, 2024 17:35
@LGLO LGLO force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch from 6db1c31 to f9c5acd Compare December 20, 2024 11:48
@LGLO
Copy link
Contributor

LGLO commented Dec 20, 2024

I admit that I've added a lot of my changes.
I've tested D-param and permissioned candidates through wizards by creating them with two different genesis utxo and updating them in total over 10 times.

@LGLO LGLO force-pushed the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch from f9c5acd to b07ebe5 Compare December 20, 2024 11:56
@LGLO LGLO enabled auto-merge (squash) December 20, 2024 11:57
@LGLO LGLO merged commit 41601bc into master Dec 20, 2024
13 of 14 checks passed
@LGLO LGLO deleted the ETCM-8949-use-permissioned-candidates-offchain-in-wizard branch December 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants