-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: ETCM-8949 use permissioned candidates offchain in wizard #315
Merged
LGLO
merged 9 commits into
master
from
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
Dec 20, 2024
Merged
change: ETCM-8949 use permissioned candidates offchain in wizard #315
LGLO
merged 9 commits into
master
from
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
2 times, most recently
from
December 10, 2024 12:45
b3f0d79
to
7cc10d5
Compare
AmbientTea
requested review from
jankun4,
LGLO and
gilligan
and removed request for
jankun4
December 10, 2024 15:44
AmbientTea
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
from
December 10, 2024 15:56
7cc10d5
to
d323646
Compare
Upsert-permissioned-cadndidates has a bug which needs to be fixed before this PR can be merged. |
LGLO
reviewed
Dec 11, 2024
LGLO
reviewed
Dec 11, 2024
AmbientTea
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
from
December 11, 2024 08:26
d323646
to
b6564f2
Compare
LGLO
approved these changes
Dec 12, 2024
LGLO
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
4 times, most recently
from
December 18, 2024 17:35
06a66f5
to
f76e54d
Compare
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
LGLO
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
from
December 20, 2024 11:48
6db1c31
to
f9c5acd
Compare
I admit that I've added a lot of my changes. |
LGLO
force-pushed
the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
from
December 20, 2024 11:56
f9c5acd
to
b07ebe5
Compare
LGLO
deleted the
ETCM-8949-use-permissioned-candidates-offchain-in-wizard
branch
December 20, 2024 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the Rust implementation of the upsert-permissioned-candidates operation instead of relying on the
pc-contracts-cli
in the wizard.Checklist
changelog.md
for affected crateNote on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.