upload debug logs #308
Open
upload debug logs #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsporny
reviewed
Dec 10, 2024
Comment on lines
+113
to
+123
| if [[ "${{ inputs.keyword }}" == "test_get_status or test_get_params" ]]; then | ||
| TEST_PHASE="smoke" | ||
| elif [[ "${{ inputs.tests }}" == "postmerge" ]]; then | ||
| if [[ "${{ inputs.mc_epoch }}" == "3" ]]; then | ||
| TEST_PHASE="postmerge-final" | ||
| else | ||
| TEST_PHASE="postmerge-epoch${{ inputs.mc_epoch }}" | ||
| fi | ||
| else | ||
| TEST_PHASE="premerge" | ||
| fi |
There was a problem hiding this comment.
This won't scale well when we add/change test suites. Debug logs are used when something fails, so let's just use the same name for every artifact and overwrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store logs for E2E tests in ci.
Checklist
changelog.mdfor affected crateNote on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.