Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-8754: implement register tx submit #299

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

kpinter-iohk
Copy link
Contributor

@kpinter-iohk kpinter-iohk commented Dec 5, 2024

Description

This PR implements candidate registration transaction submission and provides a CLI for it as well.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@kpinter-iohk kpinter-iohk force-pushed the ETCM-8754-implement-register-tx-submit branch from 09ed96c to 461c574 Compare December 5, 2024 15:55
@kpinter-iohk kpinter-iohk marked this pull request as ready for review December 5, 2024 15:55
@kpinter-iohk kpinter-iohk force-pushed the ETCM-8754-implement-register-tx-submit branch 3 times, most recently from 7ea63af to e716d0a Compare December 6, 2024 13:36
@kpinter-iohk kpinter-iohk force-pushed the ETCM-8754-implement-register-tx-submit branch 2 times, most recently from 34e596a to 56d3de7 Compare December 9, 2024 10:10
toolkit/offchain/src/register.rs Outdated Show resolved Hide resolved
toolkit/offchain/src/register.rs Outdated Show resolved Hide resolved
toolkit/offchain/src/register.rs Outdated Show resolved Hide resolved
toolkit/offchain/src/register.rs Outdated Show resolved Hide resolved
@kpinter-iohk kpinter-iohk force-pushed the ETCM-8754-implement-register-tx-submit branch 2 times, most recently from 7915b68 to a68fe4b Compare December 10, 2024 11:45
@kpinter-iohk kpinter-iohk enabled auto-merge (squash) December 10, 2024 11:45
@kpinter-iohk kpinter-iohk force-pushed the ETCM-8754-implement-register-tx-submit branch from a68fe4b to f251406 Compare December 10, 2024 11:49
@kpinter-iohk kpinter-iohk merged commit 95736ba into master Dec 10, 2024
14 checks passed
@kpinter-iohk kpinter-iohk deleted the ETCM-8754-implement-register-tx-submit branch December 10, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants