Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: ETCM-8949 use native upsert_d_param in wizard #289

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Dec 3, 2024

Description

Uses the native Rust offchain implementation to update D-Param in the setup-main-chain-state command in wizard.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea force-pushed the ETCM-8949-use-upsert-d-param branch 2 times, most recently from 83998cf to 288181c Compare December 3, 2024 17:11
@AmbientTea AmbientTea changed the base branch from master to addresses-command December 3, 2024 17:11
@AmbientTea
Copy link
Contributor Author

TODO: test manually the whole process

Base automatically changed from addresses-command to master December 3, 2024 17:25
@AmbientTea
Copy link
Contributor Author

AmbientTea commented Dec 5, 2024

edit: issue identified and fixed by @jankun4 in #300

Running the setup-main-chain-state results in an error when iserting D-Param, at the evaluateTransaction call to Ogmios. Full error message from Ogmios:

{
  "jsonrpc": "2.0",
  "method": "evaluateTransaction",
  "error": {
    "code": 3010,
    "message": "Some scripts of the transactions terminated with error(s).",
    "data": [
      {
        "validator": {
          "index": 0,
          "purpose": "mint"
        },
        "error": {
          "code": 3012,
          "message": "Some of the scripts failed to evaluate to a positive outcome. The field 'data.validationError' informs about the nature of the error, and 'data.traces' lists all the execution traces collected during the script execution.",
          "data": {
            "validationError": "An error has occurred:\nThe machine terminated because of an error, either from a built-in function or from an explicit use of 'error'.",
            "traces": [
              "ERROR-VERSION-CURRENCY-01"
            ]
          }
        }
      }
    ]
  },
  "id": 0
}

values used:

  • genesis utxo: 4bb54606e8d4396e356fa490bffb027fec80af4aa6848f9c6bd062972273c4d0#1
  • P/R: 5/5
  • init-governance transaction: 98e43bffc3934145b077e2001dfc1343b934031adb558cf801883b358e5dff5b

@AmbientTea AmbientTea force-pushed the ETCM-8949-use-upsert-d-param branch 6 times, most recently from 22e64b8 to 820234d Compare December 9, 2024 14:26
@AmbientTea AmbientTea requested review from LGLO and jankun4 December 9, 2024 14:27
@AmbientTea AmbientTea marked this pull request as ready for review December 9, 2024 14:27
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
@AmbientTea AmbientTea force-pushed the ETCM-8949-use-upsert-d-param branch from 820234d to 4b16afc Compare December 9, 2024 16:05
@AmbientTea AmbientTea changed the base branch from master to ETCM-8950-expose-upsert-d-parameter-as-the-node-command December 9, 2024 16:05
@AmbientTea AmbientTea merged commit c86c67f into ETCM-8950-expose-upsert-d-parameter-as-the-node-command Dec 9, 2024
14 checks passed
@AmbientTea AmbientTea deleted the ETCM-8949-use-upsert-d-param branch December 9, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants