-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: ETCM-8949 use native upsert_d_param in wizard #289
Merged
AmbientTea
merged 6 commits into
ETCM-8950-expose-upsert-d-parameter-as-the-node-command
from
ETCM-8949-use-upsert-d-param
Dec 9, 2024
Merged
change: ETCM-8949 use native upsert_d_param in wizard #289
AmbientTea
merged 6 commits into
ETCM-8950-expose-upsert-d-parameter-as-the-node-command
from
ETCM-8949-use-upsert-d-param
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
force-pushed
the
ETCM-8949-use-upsert-d-param
branch
2 times, most recently
from
December 3, 2024 17:11
83998cf
to
288181c
Compare
TODO: test manually the whole process |
AmbientTea
commented
Dec 3, 2024
edit: issue identified and fixed by @jankun4 in #300 Running the {
"jsonrpc": "2.0",
"method": "evaluateTransaction",
"error": {
"code": 3010,
"message": "Some scripts of the transactions terminated with error(s).",
"data": [
{
"validator": {
"index": 0,
"purpose": "mint"
},
"error": {
"code": 3012,
"message": "Some of the scripts failed to evaluate to a positive outcome. The field 'data.validationError' informs about the nature of the error, and 'data.traces' lists all the execution traces collected during the script execution.",
"data": {
"validationError": "An error has occurred:\nThe machine terminated because of an error, either from a built-in function or from an explicit use of 'error'.",
"traces": [
"ERROR-VERSION-CURRENCY-01"
]
}
}
}
]
},
"id": 0
} values used:
|
AmbientTea
force-pushed
the
ETCM-8949-use-upsert-d-param
branch
6 times, most recently
from
December 9, 2024 14:26
22e64b8
to
820234d
Compare
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
Signed-off-by: Nikolaos Dymitriadis <[email protected]>
AmbientTea
force-pushed
the
ETCM-8949-use-upsert-d-param
branch
from
December 9, 2024 16:05
820234d
to
4b16afc
Compare
AmbientTea
changed the base branch from
master
to
ETCM-8950-expose-upsert-d-parameter-as-the-node-command
December 9, 2024 16:05
jankun4
approved these changes
Dec 9, 2024
AmbientTea
merged commit Dec 9, 2024
c86c67f
into
ETCM-8950-expose-upsert-d-parameter-as-the-node-command
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the native Rust offchain implementation to update D-Param in the
setup-main-chain-state
command in wizard.Checklist
changelog.md
for affected crateNote on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.