Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement artifact builder for CardanoDatabase #2159

Merged
merged 14 commits into from
Dec 6, 2024
Merged

Feat: implement artifact builder for CardanoDatabase #2159

merged 14 commits into from
Dec 6, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Dec 3, 2024 •
edited
Loading

Content

This PR introduces the initial implementation of the artifact builder for the incremental Cardano DB.

It provides a basic scaffold for the artifact builder with a minimal working implementation.

The next steps will focus on implementing the ancillary archive, immutable file archives, and the digests file.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2151

@dlachaume dlachaume self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   11m 56s ⏱️ +15s
1 428 tests +3  1 428 ✅ +3  0 💤 ±0  0 ❌ ±0 
1 639 runs  +3  1 639 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit d27a9a6. ± Comparison against base commit 490e2c9.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet December 3, 2024 17:58 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just some suggestions

mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the dlachaume/2151/implement-artifact-builder-cardano-database branch from fb29a5a to 41f2c6b Compare December 4, 2024 13:19
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 4, 2024 13:36 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 4, 2024 14:00 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍

I left few comments below.

mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/artifact_builder/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/digesters/dummy_immutable_db_builder.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
Alenar
Alenar reviewed Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🔥

I left some few comments below.

mithril-common/src/digesters/dummy_immutable_db_builder.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/entities/cardano_database.rs Outdated Show resolved Hide resolved
mithril-common/src/digesters/dummy_immutable_db_builder.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 4, 2024 18:31 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2151/implement-artifact-builder-cardano-database branch from 267370e to 03fcfde Compare December 5, 2024 08:47
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 5, 2024 08:55 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume
refactor: secure and simplify /ledger and /volatile directories h…
0beef31 
…andling in `DummyImmutablesDbBuilder`
@dlachaume
chore: upgrade crate versions
d27a9a6 
* mithril-aggregator from `0.5.119` to `0.5.120`
* mithril-common from `0.4.92` to `0.4.93`
@dlachaume dlachaume force-pushed the dlachaume/2151/implement-artifact-builder-cardano-database branch from 03fcfde to d27a9a6 Compare December 5, 2024 16:52
@dlachaume dlachaume temporarily deployed to testing-sanchonet December 5, 2024 17:03 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 563dde0 into main Dec 6, 2024
54 of 57 checks passed
@dlachaume dlachaume deleted the dlachaume/2151/implement-artifact-builder-cardano-database branch December 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud