Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #98: main jobs fail with the ghcr.io upload #99

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

yvan-sraka
Copy link
Contributor

@yvan-sraka yvan-sraka commented Sep 8, 2023

@yvan-sraka yvan-sraka requested a review from angerman September 8, 2023 08:18
@yvan-sraka yvan-sraka self-assigned this Sep 8, 2023
@yvan-sraka yvan-sraka linked an issue Sep 8, 2023 that may be closed by this pull request
@angerman
Copy link
Collaborator

angerman commented Sep 9, 2023

But we don't have a required job in hydra for this, if we wait for it like we do now, it will never finish.

@angerman
Copy link
Collaborator

angerman commented Sep 9, 2023

Do note, we can't have a required job, as that would mean we end up copying all stuff to some machine to build the required job. So that's not really an option.

@angerman
Copy link
Collaborator

angerman commented Sep 9, 2023

Let's see if this does a bit better.

@angerman angerman self-assigned this Sep 9, 2023
@angerman
Copy link
Collaborator

So this is better, not ideal though. I think we could do one better with building a matrix to get it all done like here: https://www.kenmuse.com/blog/dynamic-build-matrices-in-github-actions/, however that requires a sentinel job. Maybe https://determinate.systems/posts/hydra-deployment-source-of-truth helps.

1. Hydra
2. DevX closures
3. Devcontainer
@angerman angerman force-pushed the 98-fix-main-jobs-that-fail-with-the-ghcrio-upload branch from bc4f665 to 423e3a8 Compare September 11, 2023 23:14
@angerman angerman added this pull request to the merge queue Sep 11, 2023
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

Merged via the queue into main with commit bd723cf Sep 11, 2023
34 checks passed
@yvan-sraka yvan-sraka deleted the 98-fix-main-jobs-that-fail-with-the-ghcrio-upload branch September 12, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix main jobs that fail with the ghcr.io upload
2 participants