Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configurable scheme parameter for cardano wallet api #857

Open
wants to merge 2 commits into
base: node-1.4-extension
Choose a base branch
from

Conversation

mineme0110
Copy link
Contributor

Overview

This PR allows to have configurable scheme to support switch the schemes

Screenshots

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

@mineme0110 mineme0110 requested a review from yshyn-iohk June 3, 2024 15:31
@mineme0110 mineme0110 changed the base branch from main to node-1.4-extension June 3, 2024 15:33
Signed-off-by: mineme0110 <[email protected]>
@mineme0110 mineme0110 changed the title fix: prism-node configurable scheme parameter for cardano wallet api fix: configurable scheme parameter for cardano wallet api Jun 3, 2024
Copy link

github-actions bot commented Jun 4, 2024

Unit Test Results

837 tests   836 ✔️  1m 20s ⏱️
102 suites      1 💤
102 files        0

Results for commit 7d8fe5e.

@mkbreuningIOHK mkbreuningIOHK requested a review from womfoo June 4, 2024 10:00
Copy link
Contributor

@womfoo womfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM test successful w confirmation < 1m

> Task :run
Jun 10, 2024 10:06:24 PM io.grpc.okhttp.internal.Platform getAndroidSecurityProvider
WARNING: Unable to find Conscrypt
[main] INFO org.bitcoinj.crypto.MnemonicCode - PBKDF2 took 69.86 ms
-- Create issuer DID --
DID canonical: did:prism:0be94ebde4a795e9f0d537d8489d8be6ad167f2ed674fafae35426eb1e14905d
DID long form: did:prism:0be94ebde4a795e9f0d537d8489d8be6ad167f2ed674fafae35426eb1e14905d:Cr8BCrwBEjsKB21hc3RlcjAQAUouCglzZWNwMjU2azESIQM0X7lVu_kxW-N3dFx3fA-uHgi3ek0gfSdNiTjSsZ8bzBI8Cghpc3N1aW5nMBACSi4KCXNlY3AyNTZrMRIhAqquIU6yUq4T29AcWC4QygRhuZ1VbkgYnuslFDIphXaeEj8KC3Jldm9jYXRpb24wEAVKLgoJc2VjcDI1NmsxEiECg-bV8ES7v5IIg_D28GFPI6pjcPJDWqub3IDsGuOdsBA

-- Publish DID --
- Sent a request to publish a DID to PRISM Node.
- The transaction can take up to 10 minutes to be confirmed by the Cardano network.
- Operation identifier: 569dae4269f77bac1eed4c664d63e34469ad74ce674786cd120e80b6ccf87e11

Current operation status: PENDING_SUBMISSION
Jun 10, 2024 10:06:27 PM io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference cleanQueue
SEVERE: *~*~*~ Channel ManagedChannelImpl{logId=1, target=demeter-preprod-node-v1.atalaprism.io:443} was not shutdown properly!!! ~*~*~*
    Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() returns true.
java.lang.RuntimeException: ManagedChannel allocation site
        at io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.<init>(ManagedChannelOrphanWrapper.java:93)
        at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:53)
        at io.grpc.internal.ManagedChannelOrphanWrapper.<init>(ManagedChannelOrphanWrapper.java:44)
        at io.grpc.internal.ManagedChannelImplBuilder.build(ManagedChannelImplBuilder.java:615)
        at io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:261)
        at io.iohk.atala.prism.protos.GrpcClient.<init>(GrpcClient.kt:22)
        at io.iohk.atala.prism.api.node.NodeAuthApiImpl.<init>(NodeAuthApiImpl.kt:33)
        at MainKt.<clinit>(Main.kt:28)

- DID with id did:prism:0be94ebde4a795e9f0d537d8489d8be6ad167f2ed674fafae35426eb1e14905d is published
- Operation hash: 0be94ebde4a795e9f0d537d8489d8be6ad167f2ed674fafae35426eb1e14905d


Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.4/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 34s
2 actionable tasks: 1 executed, 1 up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants