Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x psr log and php multi compat #75

Draft
wants to merge 20 commits into
base: 2.x
Choose a base branch
from

Conversation

luislard
Copy link

@luislard luislard commented Nov 28, 2023

This pull request fixes issue #.

What's Included in This Pull Request

  • Add support for psr/log 2 and 3
  • Copied TestLogger class since it is not possible to support importing it for php7 and php8 in the same composer.json
  • Enhancements in the Giihub workflows.
  • Removed coverage since it was hardcoded to PHP 7.4.

Aditional information

Supporting 3 versions of psr/log is making composer incapable to resolve to version 2 in the tests.

I ran PHPUnit tests in my local using nektos/act modifying composer.json to see the results and it passes.

act --workflows .github/workflows/php-unit-tests.yml push

The min version required of monolog has to be 2.0.1 because the BufferHandler does not meet the interface FormattableHandlerInterface see:

Seldaek/monolog@f9d56fd

Let me know your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant