Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Update package to support php >=8 and Psr Log 2 || 3 #74

Merged
merged 15 commits into from
Mar 7, 2024
Merged

refactor: Update package to support php >=8 and Psr Log 2 || 3 #74

merged 15 commits into from
Mar 7, 2024

Conversation

luislard
Copy link

@luislard luislard commented Nov 3, 2023 •
edited
Loading

Updating dependencies to be able to work with newer Psr/Log BREAKING CHANGE: we are dropping support for PHP 7.x and Psr/Log 1.x

This pull request fixes issue #.

What's Included in This Pull Request

  • Drop support for PHP 7.x
  • Drop support for Psr/Log 1.x and support Psr/Log 2.x || 3.x
  • Update of PHP Unit to v9 since it was required to achieve the goal
  • Update of Psalm since it was required to achieve the goal
  • Require the test class from the new package since the test folder was deleted from the source
  • Added new strategy in the matrix of PHPUnit testing to use --prefer-lowest and resolve to psr/log v2 during the installation
  • Added other PHP static analysis using with different PHP versions
  • Fixed Psalm issues mostly adding new annotations since Psalm does not know about different WP versions
  • Updated PHPUnit config to remove dprecation warning
  • Changed the usage of assertRegexp in test to the new method as it will be deprecated in PHPUnit 10

@luislard
refactor: Update package to support php >=8 and Psr Log 2 || 3
db215b0 
Updating dependencies to be able to work with newer Psr/Log
BREAKING CHANGE: we are dropping support for PHP 7.x and Psr/Log 1.x
@luislard
ci: remove php 7.x workflow run
83e07a3
@luislard
chore: add static analysis for php 8.0 8.1 8.2
80d0da6
@luislard
chore: add static code analysis for different php versions
3c14a3f
@luislard
chore: fixes psalm error
0c2fe9c 
Ignore error comming from the different return type on earlier versions of WP
In WP < 6.1 the return type was array[]|false
@luislard
chore: fix psalm and require the test package
e9dfe4e
@luislard
chore: remove deprecation warning in tests
685d0d3
@luislard
chore: remove phpunit warning about config file using outdated schema
c3b39a2
@luislard
chore: increase the php unit test matrix to use prefer lowest and reg…
2c9d84e 
…ular
@luislard luislard requested a review from gmazzap November 6, 2023 11:09
gmazzap
gmazzap reviewed Nov 6, 2023
View reviewed changes
.github/workflows/php-static-analysis.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/DefaultHandler/LogsFolder.php Outdated Show resolved Hide resolved
@luislard luislard requested a review from gmazzap November 8, 2023 10:02
@luislard luislard changed the base branch from 2.x to 3.x December 14, 2023 10:03
@luislard luislard marked this pull request as ready for review December 14, 2023 10:04
@luislard luislard merged commit db77d35 into 3.x Mar 7, 2024
15 checks passed
@dottxado dottxado deleted the 3.x-proposal branch March 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmazzap gmazzap gmazzap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luislard @gmazzap