Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/refactor: filestore feature flag #4617

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Schwehn42
Copy link
Collaborator

Description

Wraps the experimental file store (#4600) inside a feature flag.

Changelog

  • moved file store code to router.go, so it only gets executed once
  • add new flag/env var SCRUMLR_ENABLE_EXPERIMENTAL_AUTH_FILE_SYSTEM_STORE
  • use file store if env var is set to true
  • add docs

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Nov 8, 2024
@Schwehn42 Schwehn42 self-assigned this Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

The deployment to the dev cluster was successful. You can find the deployment here: https://4617.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-301f67f

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-301f67f

Copy link

octomind-dev bot commented Nov 8, 2024

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 301f67f

@Schwehn42 Schwehn42 added Blocked This pull request or issue is currently blocked by another issue and removed Review Needed This pull request is ready for review labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked This pull request or issue is currently blocked by another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant