remove personal votes #4616
remove personal votes #4616
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/store/features/votes/reducer.ts
Outdated
| }) | ||
| .addCase(updatedVoting, (_state, action) => action.payload.notes?.map((n) => ({voting: action.payload.voting.id, note: n.id}))) |
There was a problem hiding this comment.
we added this during bug hunting, but is it actually still relevant?
There was a problem hiding this comment.
Good eye👀, I had forgotten about that, removed it :)
src/store/features/votes/reducer.ts
Outdated
| state.push(action.payload); | ||
| state.unshift(action.payload); |
There was a problem hiding this comment.
looking at it now, I think I prefer pushing over unshifting and taking the last element instead of the first in the relevant code. Just to be in line with the other reducers
There was a problem hiding this comment.
(only if you don't plan on changing the backend though, because it wouldn't matter otherwise)
There was a problem hiding this comment.
I changed it back and implemented filters so that only the most recent votes and voting in the InitEvent are sent
Schwehn42
added
Changes Requested
mateo-ivc
added
Review Needed
|
The deployment to the dev cluster was successful. You can find the deployment here: https://4616.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 7/14 successful.
commit sha: 80cc739 |
server/src/api/event_filter.go
Outdated
| @@ -312,6 +311,18 @@ func (boardSubscription *BoardSubscription) eventFilter(event *realtime.BoardEve | |||
|
|
|||
| func eventInitFilter(event InitEvent, clientID uuid.UUID) InitEvent { | |||
| isMod := isModerator(clientID, event.Data.BoardSessions) | |||
| latestVoting := event.Data.Votings[0] | |||
There was a problem hiding this comment.
this leads to an error on a new board which has no votings yet:
2024-11-20T12:26:03.515343879Z panic: runtime error: index out of range [0] with length 0
2024-11-20T12:26:03.515345713Z
2024-11-20T12:26:03.515346963Z -> scrumlr.io/server/api.eventInitFilter
2024-11-20T12:26:03.515348546Z -> /go/src/github.com/inovex/scrumlr.io/api/event_filter.go:314
There was a problem hiding this comment.
Hi, still multiple issues here unfortunately
- Votes by new participants and/or new notes after a voting has concluded don't seem to apply
- Reloading after starting a new voting, after one has already concluded gives the result of the first voting, not the new empty one
- Whatever the heck this is 💀:
Description
The problem was that if a user re-joins the board during a vote, they lose all votes except their own.
The reason for this is that the
Fullboardmethod only queries the votes that the user has created.Changelog
boards/boards.govotes/reducerapi/event-filterChecklist
(Optional) Visual Changes