feat(elements|ino-datepicker): provide error property #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfecht
previously approved these changes
Sep 16, 2021
| /** | ||
| * Displays the datepicker as invalid if set to true. | ||
| * If the property is not set or set to false, | ||
| * the validation is handled by the default validation. |
There was a problem hiding this comment.
Shouldn't the error prop have three states:
null|undefined=> use native validationtrue=> has errorfalse=> has no error
If I integrate the component and manually set the error=false, I wouldn't suggest that the component still natively validates.
This may be something we should unify across all components
janivo
requested changes
Oct 12, 2021
packages/elements/src/components/ino-datepicker/ino-datepicker.tsx
Outdated
Show resolved
Hide resolved
janivo
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #423
Proposed Changes
errorto enable error state programmatically