Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: suppress NX unknown cache error #1218

Merged
merged 3 commits into from
Feb 2, 2024
Merged

ci: suppress NX unknown cache error #1218

merged 3 commits into from
Feb 2, 2024

Conversation

janivo
Copy link
Collaborator

@janivo janivo commented Feb 1, 2024

No description provided.

@janivo janivo requested a review from BenPag February 1, 2024 08:50
BenPag
BenPag requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@BenPag BenPag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the env setting for the yarn lint and yarn test command too?

Also we should check other workflow files.

@janivo janivo force-pushed the elements-ci-fix-cache-error branch from 1128c05 to f403342 Compare February 2, 2024 10:54
BenPag
BenPag requested changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@BenPag BenPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waht about the prerelease and the release workflow? There we use yarn build too.

And also for the deploy-landingpage workflow

.github/workflows/test.yml Outdated Show resolved Hide resolved
@janivo janivo requested a review from BenPag February 2, 2024 11:31
@janivo janivo merged commit b8f8d3d into master Feb 2, 2024
3 of 4 checks passed
@janivo janivo deleted the elements-ci-fix-cache-error branch February 2, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPag BenPag BenPag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janivo @BenPag