Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrypt only once and hold calendar auth data in memory #91

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Decrypt only once and hold calendar auth data in memory #91

merged 5 commits into from
Oct 27, 2023

Conversation

alxndr13
Copy link
Contributor

@alxndr13 alxndr13 commented Oct 16, 2023 •
edited
Loading

fixes #88 and #29

@alxndr13
Copy link
Contributor Author

Probably a bit rushed, but works :)

MichaelEischer
MichaelEischer reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks like it works, although I'd prefer to clean it up a bit.

internal/auth/yaml_storage.go Outdated Show resolved Hide resolved
internal/auth/yaml_storage.go Outdated Show resolved Hide resolved
internal/auth/yaml_storage.go Outdated Show resolved Hide resolved
internal/auth/yaml_storage.go Outdated Show resolved Hide resolved
@MichaelEischer MichaelEischer linked an issue Oct 17, 2023 that may be closed by this pull request
Decrypt credentials only once #29
Closed
@alxndr13 alxndr13 merged commit c0d2d8b into main Oct 27, 2023
5 checks passed
@alxndr13 alxndr13 deleted the fix-decrypt-only-once branch October 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelEischer MichaelEischer MichaelEischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime is too long Decrypt credentials only once
2 participants
@alxndr13 @MichaelEischer