Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add version flag #52

Merged
merged 5 commits into from
Aug 10, 2023
Merged

feat: add version flag #52

merged 5 commits into from
Aug 10, 2023

Conversation

alxndr13
Copy link
Contributor

@alxndr13 alxndr13 commented Aug 2, 2023 •
edited
Loading

  • feat: add version flag
  • fix: github build workflow
  • fix: add missing ldflags to goreleaser

@alxndr13
Copy link
Contributor Author

alxndr13 commented Aug 2, 2023 •
edited
Loading

i needed to remove the required option from the --storage-encryption-key flag , otherwise the flag is also needed for the version command

edit: not relevant anymore as we switched to the --version flag

MichaelEischer
MichaelEischer reviewed Aug 2, 2023
View reviewed changes
cmd/calendarsync/main.go Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@alxndr13 alxndr13 changed the title feat: add version command feat: add version flag Aug 4, 2023
@MichaelEischer MichaelEischer linked an issue Aug 5, 2023 that may be closed by this pull request
Version is not properly injected during build #51
Closed
@alxndr13 alxndr13 merged commit 63c2516 into main Aug 10, 2023
5 checks passed
@alxndr13 alxndr13 deleted the feat-add-version-command branch August 10, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelEischer MichaelEischer MichaelEischer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version is not properly injected during build
2 participants
@alxndr13 @MichaelEischer