Fix/object-key-convention #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: change message name to information
|
@miguelgarcia can you assign yourself reviewer |
Comment on lines
+1174
to
+1175
| "orderId": order.order_id, | ||
| "orderUpdateId": order.order_update_id, |
There was a problem hiding this comment.
This are already handled by vda5050_connector_py/mqtt_bridge.py using convert_ros_message_to_json, aren't they ?
Comment on lines
+1212
to
+1222
| VDAErrorReference(reference_key="orderId", reference_value=order.order_id) | ||
| ) | ||
| error_references.append( | ||
| VDAErrorReference( | ||
| reference_key="order_update_id", reference_value=str(order.order_update_id) | ||
| reference_key="orderUpdateId", reference_value=str(order.order_update_id) | ||
| ) | ||
| ) | ||
| elif error == OrderRejectErrors.NO_ROUTE_ERROR: | ||
| # On noRouteError send 1st node as reference | ||
| error_references.append( | ||
| VDAErrorReference(reference_key="node_id", reference_value=order.nodes[0].node_id) | ||
| VDAErrorReference(reference_key="nodeId", reference_value=order.nodes[0].node_id) |
There was a problem hiding this comment.
This are ok to change because it seems they aren't handled by convert_ros_message_to_json()
vda5050_msgs/msg/OrderState.msg
Outdated
| @@ -65,7 +65,7 @@ string operating_mode # Enum {AUTOMATIC, SEMIAUTO | |||
|
|
|||
| vda5050_msgs/Error[] errors # Array of errorobjects. Empty array if there are no errors. | |||
|
|
|||
| vda5050_msgs/Info[] informations # Array of info-objects. An empty array indicates that the AGV has no information. | |||
| vda5050_msgs/Info[] information # Array of info-objects. An empty array indicates that the AGV has no information. | |||
There was a problem hiding this comment.
Hey I believe all changes to this field name must be in the same PR. If we merge this PR as is, it can break stuff such as vda5050_connector_py/vda5050_controller.py because it still references informations field
There was a problem hiding this comment.
this shouldnt be here it is my wrong there are 2 separated merge request (informations and convention) I can revert it
This reverts commit bb36596.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue ticket, object key conversions have been changed to camelCase as stated in the documentation.
#48