API version selector #23
Open
+24
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an api version to api python class dictionary
elvioaruta
reviewed
Oct 29, 2024
Comment on lines
+6
to
+8
| APIS = { | ||
| "v2.0": {"rest": MirApiV2, "ws": MirWebSocketV2}, | ||
| } |
There was a problem hiding this comment.
Without having much context, are we sure these versions are fixed?
E.g: V2.0 means V2 for Rest and WS?
Could it happen that a model uses different APIs versions for WS and rest?
|
The implementation looks good, just added a comment related to something that I'm not sure of. If those API versions are fixed, then this PR looks good to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds an API version to API python class dictionary.
When an unsupported API version is specified, the error message displays: