Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ports as param for loadbalancer mutations #244

Conversation

sthwang-metal
Copy link
Contributor

Loadbalancers and ports have a 1:m relationship and so for

  • lb creation: lb needs to be created before ports can be made
  • lb update: ports only exist as part of a lb so doesnt make sense to add ports from other lbs to a lb

Thus we should remove this api param since it is redundant.

@sthwang-metal sthwang-metal requested review from a team as code owners October 4, 2023 18:12
@sthwang-metal sthwang-metal force-pushed the sthwang/remove-api-lb-params branch 3 times, most recently from c248129 to 5118ded Compare October 5, 2023 16:44
@sthwang-metal sthwang-metal force-pushed the sthwang/remove-api-lb-params branch from 5118ded to 29035ec Compare October 7, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant