(DEL-2899) Make Port Name Optional (#287)

* make port name optional Signed-off-by: Stephen Hwang <[email protected]> * fix unit tests Signed-off-by: Stephen Hwang <[email protected]> --------- Signed-off-by: Stephen Hwang <[email protected]>
infratographer · Dec 6, 2023 · d85a9ac · d85a9ac
1 parent 40a661c
commit d85a9ac
Show file tree

Hide file tree

Showing 10 changed files with 25 additions and 49 deletions.
diff --git a/internal/ent/generated/port/port.go b/internal/ent/generated/port/port.go
diff --git a/internal/ent/generated/port_create.go b/internal/ent/generated/port_create.go
diff --git a/internal/ent/generated/port_update.go b/internal/ent/generated/port_update.go
diff --git a/internal/ent/generated/runtime.go b/internal/ent/generated/runtime.go
diff --git a/internal/ent/schema/port.go b/internal/ent/schema/port.go
@@ -48,7 +48,6 @@ func (Port) Fields() []ent.Field {
 				entgql.OrderField("number"),
 			),
 		field.String("name").
-			NotEmpty().
 			Annotations(
 				entgql.OrderField("name"),
 			),

diff --git a/internal/graphapi/loadbalancer.resolvers.go b/internal/graphapi/loadbalancer.resolvers.go
diff --git a/internal/graphapi/origin.resolvers.go b/internal/graphapi/origin.resolvers.go
diff --git a/internal/graphapi/pool.resolvers.go b/internal/graphapi/pool.resolvers.go
diff --git a/internal/graphapi/port.resolvers.go b/internal/graphapi/port.resolvers.go
diff --git a/internal/graphapi/port_test.go b/internal/graphapi/port_test.go
@@ -53,13 +53,16 @@ func TestCreate_LoadbalancerPort(t *testing.T) {
 			},
 		},
 		{
-			TestName: "fails to create loadbalancer port with empty name",
+			TestName: "succeeds in creating loadbalancer port with empty name",
 			Input: graphclient.CreateLoadBalancerPortInput{
 				Name:           "",
 				LoadBalancerID: lb.ID,
-				Number:         22,
+				Number:         23,
+			},
+			Expected: &graphclient.LoadBalancerPort{
+				Name:   "",
+				Number: 23,
 			},
-			errorMsg: "value is less than the required length",
 		},
 		{
 			TestName: "fails to create loadbalancer port with empty loadbalancer id",
@@ -220,12 +223,15 @@ func TestUpdate_LoadbalancerPort(t *testing.T) {
 			},
 		},
 		{
-			TestName: "fails to update loadbalancer port name to empty",
+			TestName: "succeeds in updating loadbalancer port name to empty",
 			ID:       port.ID,
 			Input: graphclient.UpdateLoadBalancerPortInput{
 				Name: newString(""),
 			},
-			errorMsg: "value is less than the required length",
+			Expected: &graphclient.LoadBalancerPort{
+				Name:   "",
+				Number: 22,
+			},
 		},
 		{
 			TestName: "fails to update loadbalancer port number < min",