ACL mgmt url-decode fix #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the role is URL-quoted in the API and needs to be unquoted when compared to ACL arrays in the database. this seems to be broken since the code was refactored for Flask and other implicit URL unquoting was removed from the dispatch path.
1. The role must be unquoted when probing the database content 2. The role should be quoted in URLs within NotFound errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the /hatrac/path/name;acl/access/entry resources that allow addressing of individual entries in an access control list.
Since some time during the Flask port and general revision to how URLs are parsed and dispatched, these haven't been working as they need to. The entry value will be URL encoded, e.g. when it is a URI, but this needs to be decoded before it is mapped to the underlying ACL storage in the database. It also needs to be re-encoded when generating a NotFound exception that names the specific ACL entry.
(This is different than namespace and object names which we keep encoded even in the database, and that's where the regression stems from.)