-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom filename for content-disposition #1010
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaded has a different file name
… filename_stem as a property to the templating environment for files
RFSH
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should also update line 449 and 452 (where you recently changed so we would update the filename of already uploaded files) to use .storedFilename
instead of .file.name
.
Apart from that everything looks good to me and test cases passed locally.
RFSH
requested changes
Mar 28, 2024
RFSH
reviewed
Mar 28, 2024
RFSH
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for an new annotation property on the asset annotation,
stored_filename_pattern
. This property will allow for data modelers to customize thecontent-disposition
value that is stored in hatrac for the file and the value stored in thefilename_column
(if defined on the annotation). This pattern uses the same template variables asurl_pattern
with a new one added calledfilename_stem
, the name of the file without the extension.More details in the comment on issue 1949 in chaise.