-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record presentation playwright #2519
Conversation
… of a separate function since it isn't actually reused in any other .spec.ts files
…rom catalog IDs used in github actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to run the test cases and everything is working as expected. I really like that you moved the one-time-use function in record-helpers to be directly inside the spec. I always disliked how that function has a generic name but it was implemented for just this one page.
My comments are mostly about reusing the functions that we've already added.
P.S. Please update this branch with the latest master changes. It still has the alias creation step, so I had to manually remove that to be able to run the test cases.
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
@RFSH I updating this PR with the changes you asked for and what I mentioned in slack about testing BDBag in GA. I also updated the top comment to include details about each change that was out of the ordinary. The major change since you last reviewed that I want to draw attention to is about testing the main record section values:
I did notice that the "export" tests I wrote are almost the same as the ones in the other spec but decided not to add a helper function for this since Although, now that I'm thinking about it more, that's like having |
test/e2e/specs/all-features-confirmation/record/presentation.spec.ts
Outdated
Show resolved
Hide resolved
…ed string. testExportDropdown added
Migrate record presentation spec and remove old protractor spec files.
Changes in this PR besides the test migration:
resolverImplicitCatalog
to100
to avoid colliding with a catalog number that GA will use each time the tests runresolverImplicitCatalog = 2
was fine beforetestRecordMainSectionValues
to test inline related table values when the custom mode shows a single linkRecordsetColValue
type inrecordset-utils.ts
testRelatedTablePresentation
to check if the table is in tabular mode, if it isn't click the button so the following tests won't failtest.skip
forBDBag
tests in CI