Properly handle array inputs in iframe-field-modal #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to merging #2340, array values were stored as strings in react-hook-form. So the
iframe-field-modal.tsxcode wasn't doing anything special for the arrays andpopulateSubmissionRowwould eventually turn this string into a proper array.However, with the new implementation, we expect array values to follow a specific pattern, and this PR will make sure this component also stores array values properly.
Because of this bug, after users select a value using the iframe, as soon as the
populateSubmissionRowwas called (due to opening a foreign key popup or clicking on submit), they would see a terminal error with the following messageP.S. I also changed the test case to have an array column, so we can test this scenario.