-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc facet playwright #2484
Misc facet playwright #2484
Conversation
…em locally with an error from ermrestJS
… if it fixes failures in CI
… protractor config and update makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes that you've done and love how fast the playwright facet spec is!
I just have some minor suggestions before pushing the changes:
-
While I didn't see any issues related to this, but to make sure it doesn't cause issues at some point in the future, you should make sure the modal is closed after clicking on the close button. So basically when you're doing
getCloseBtn().click
, the next line should be:await expect.soft(modal).not.toBeAttached();
. We could have a helper function for this too. The function would do the click and wait for the modal to disappear. It's up to you if a function is needed or not. -
Like I mentioned in my inline comment, I think your new functions need jsdoc so it's easier to know what they're doing.
-
I think we should rename
ind-facet.config.ts
to something likemain-facet.config.ts
or justfacet.config.ts
. It's a bit confusing that it's using the same name as one of the specs, but it includes more than just that one spec.
…to functions, wait for modal to not be attached
In this PR, the
misc-facet
spec is migrated to playwright. With this, all of the delete prohibited specs are also migrated so that protractor configuration is removed as well. I also removed the command in the makefile and updatede2e.yml
.Other changes in this PR: