Improvements to copy to clipboard feature #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o users the share and cite popup links were not using the same function as permalink, and were only using the deprecated API for clipboard which wasn't working properly on some browsers. we also decided to change the tooltip as a feedback to users. to make sure the tooltip is displayed in the proper place I had to change the tooltip component a bit.
jrchudy
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR,
copyToClipboardfunction to return a promise.ChaiseTooltipcomponent to remount the tooltip if its content has changed. Without this change the tooltip arrowhead position would stay in the same place. As a result the tooltip would go outside the window in some cases.