Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter does not submit recordedit form #2356

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Enter does not submit recordedit form #2356

merged 3 commits into from
Sep 12, 2023

Conversation

jrchudy
Copy link
Member

@jrchudy jrchudy commented Sep 12, 2023

This Pull request will stop the "enter" key from submitting the recordedit form when certain input types have the cursor in them. This was occurring for the text, date, and numeric inputs. This functionality will intercept the enter key event and prevent the default browser event from occurring (form submission).

Some of our inputs rely on the enter event, those inputs include array, longtext, markdown, json, and jsonb. For those cases, a boolean is defined that ignores this intercept event since the textarea element defines its own on enter functionality.

The foreign key dropdown input relies on enter to submit the search text but this is unaffected by this change since the search input component defines it's own on enter for the input element.

@jrchudy jrchudy added the bug label Sep 12, 2023
@jrchudy jrchudy requested a review from RFSH September 12, 2023 02:35
@jrchudy jrchudy self-assigned this Sep 12, 2023
@jrchudy jrchudy merged commit 926d978 into master Sep 12, 2023
1 check passed
@jrchudy jrchudy deleted the input-on-enter branch September 12, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants