Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2320 allow input value copied to selected rows #2345
2320 allow input value copied to selected rows #2345
Changes from 10 commits
0b3d17b
c5f58ab
6de4adc
899831c
7990375
0e90d70
8aab268
9120faf
98887fd
5536186
2602987
41b550e
7716e23
907534d
7763382
5944a2a
5ecfa7f
e3acd5e
9649a05
2fd07da
9fcb4fc
7de2057
4886ad8
44164bc
9414627
71b0e2b
75bc773
6ef4b70
48a4575
7857d42
9b0fbcf
96552f1
f9a9769
63de612
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain why this is needed. You should also move it to be inside
.center-align
rule above, like this:&
refers to the parent selector.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a child class for centre-align, it is a separate class for textarea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know.
.centre-align-textarea
is a more specific class that you're adding to only some.centre-align
elements. That's why I wrote it as&.centre-align-textarea
.In scss just because you're writing a rule inside another one doesn't mean that it will always go another level deep. It just means start from there.
&
in here refers to.centre-align
elements and by appending.centre-align-textarea
to it, we're basically saying all the.centre-align.centre-align-textarea
elements.If I you were to just say
.centre-align-textarea
or& .centre-align-textarea
then it would be different and not what we want.Also let's use
center
instead ofcentre
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move it up there. The values in this map are sorted for readability purposes.