recordedit simple array support. #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like moment has a pre-defined ISO 8601 format. So I just used that for validating timestamp columns. |
jrchudy
approved these changes
Feb 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add simple array support to recordedit. We are going to show a texarea for arrays and it has its own set of custom validators.
I added test cases to
edit.spec.js,add.spec.js, andadd-x-forms.spec.js(batch-copy feature).The only thing that I wasn't sure of is the timestamp format. Which formats should we allow? Should we be flexible i.e. allow only dates, allow timestamptz without specifying timezone? Currently I haven't specified any formats, but I feel like I should just allow a certain list of formats. We might want to discuss about this in the meeting.
#1408