revert the change to allow more tests on CI

.github/workflows/e2e.yml

@@ -145,12 +145,12 @@ jobs:
         run: |
           cd chaise
           make testallfeatures
-      # - name: Run all features confirmation test spec
-      #   id: test-all-features-confirmation
-      #   continue-on-error: true
-      #   run: |
-      #     cd chaise
-      #     make testallfeaturesconfirmation
+      - name: Run all features confirmation test spec
+        id: test-all-features-confirmation
+        continue-on-error: true
+        run: |
+          cd chaise
+          make testallfeaturesconfirmation
       - name: Run default config test spec
         id: test-default-config
         continue-on-error: true
@@ -166,9 +166,9 @@ jobs:
       - name: Check on all features test spec
         if: always() && steps.test-all-features.outcome != 'success'
         run: exit 1
-      # - name: Check on all features confirmation test spec
-      #   if: always() && steps.test-all-features-confirmation.outcome != 'success'
-      #   run: exit 1
+      - name: Check on all features confirmation test spec
+        if: always() && steps.test-all-features-confirmation.outcome != 'success'
+        run: exit 1
       - name: Check on default config test spec
         if: always() && steps.test-default-config.outcome != 'success'
         run: exit 1

test/e2e/specs/all-features-confirmation/record/presentation.spec.ts

@@ -282,14 +282,14 @@ test.describe('View existing record', () => {
         { title: 'color_rgb_hex_column', value: '  #323456', match: 'html' }
       ];
 
-      // if (!process.env.CI) {
+      if (!process.env.CI) {
         await test.step('delete files', async () => {
           // delete files that may have been downloaded before
           await deleteDownloadedFiles(testParams.file_names.map((name: string) => {
             return `${DOWNLOAD_FOLDER}/${name}`
           }));
         });
-      // }
+      }
 
       const notNullColumns = testParams.columns.filter((c: any) => {
         return !c.hasOwnProperty('value') || c.value !== null;
@@ -554,14 +554,14 @@ test.describe('View existing record', () => {
         }
       });
 
-      // if (!process.env.CI) {
+      if (!process.env.CI) {
         await test.step('delete files', async () => {
           // delete files that may have been downloaded during tests
           await deleteDownloadedFiles(testParams.file_names.map((name: string) => {
             return `${DOWNLOAD_FOLDER}/${name}`
           }));
         });
-      // }
+      }
     });
   });
 

test/e2e/specs/all-features-confirmation/recordset/presentation.spec.ts

@@ -338,13 +338,13 @@ test.describe('View recordset', () => {
     });
 
     await test.step('presentation of the recordset page', async () => {
-      // if (!process.env.CI) {
+      if (!process.env.CI) {
         await test.step('delete files that may have been downloaded before', async () => {
           await deleteDownloadedFiles(params.file_names.map((name: string) => {
             return `${DOWNLOAD_FOLDER}/${name}`
           }));
         });
-      // }
+      }
 
       await test.step(`should have ${params.title} as title`, async () => {
         await expect.soft(RecordsetLocators.getPageTitleElement(page)).toHaveText(params.title);
@@ -521,13 +521,13 @@ test.describe('View recordset', () => {
         await expect.soft(RecordsetLocators.getRows(page)).toHaveCount(3)
       });
 
-      // if (!process.env.CI) {
+      if (!process.env.CI) {
         await test.step('delete files downloaded during the tests', async () => {
           await deleteDownloadedFiles(params.file_names.map((name: string) => {
             return `${DOWNLOAD_FOLDER}/${name}`
           }));
         });
-      // }
+      }
 
     });
 

test/e2e/specs/default-config/record/links.spec.ts

@@ -20,7 +20,7 @@ test.describe.configure({ mode: 'parallel' });
 
 test.describe('links on the record page', () => {
   test('The proper permalink should appear in the share popup if resolverImplicitCatalog is undefined', async ({ page, baseURL }, testInfo) => {
-    // test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
+    test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
 
     await goToPage(page, baseURL, testInfo, testParams.table_name, true);
 
@@ -46,7 +46,7 @@ test.describe('links on the record page', () => {
   });
 
   test('Searching in go to RID input should navigate the user to the resolved record page matching that RID', async ({ page, baseURL }, testInfo) => {
-    // test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
+    test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
 
     await goToPage(page, baseURL, testInfo, testParams.table_name, true);
 

test/e2e/specs/delete-prohibited/navbar/catalog-chaise-config.spec.ts

@@ -208,11 +208,11 @@ const testNavbarFunctionalities = async (page: Page, pageURL: string, isStatic?:
     await expect.soft(loginMenuOption).toHaveText('Outbound Profile Link')
   });
 
-  // if (!process.env.CI) {
+  if (!process.env.CI) {
     await test.step('should open a new tab when clicking the link for the login information', async () => {
       const newPage = await clickNewTabLink(loginMenuOption);
 
       await newPage.close();
     });
-  // }
+  }
 }

test/e2e/specs/delete-prohibited/record/no-delete-btn.spec.ts

@@ -77,7 +77,7 @@ test.describe('record page with specific chaise-config properties', () => {
   });
 
   test('should show an error dialog if an improper RID is typed into the RID search box', async ({ page }) => {
-    // test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
+    test.skip(!!process.env.CI, 'in CI the resolver server component is not configured and cannot be tested');
 
     await NavbarLocators.getGoToRIDInput(page).clear();
     await NavbarLocators.getGoToRIDInput(page).fill('someobviouslywrongRID');

test/e2e/specs/delete-prohibited/recordset/facet-presentation.spec.ts

@@ -100,14 +100,14 @@ test('Viewing Recordset with Faceting, default presentation based on facets anno
     await expect.soft(RecordsetLocators.getCheckedFacetOptions(facet)).toHaveCount(1);
   });
 
-  // if (!process.env.CI) {
+  if (!process.env.CI) {
     // NOTE: the page would load and every check would succeed until this check where only 1 filter would be shown
     //   - noticed the id filter would show but the int_col facet would not have a selection or a filter shown
     //   - can't understand why this is happening in github actions. this can't be reproduced locally
     await test.step('should have 2 filters selected', async () => {
       await expect.soft(RecordsetLocators.getFacetFilters(page)).toHaveCount(testParams.defaults.numFilters);
     });
-  // }
+  }
 
   await test.step('should have 1 row selected in show more popup for scalar picker and should be able to search in popup.', async () => {
     const facet = RecordsetLocators.getFacetById(page, 0);

test/e2e/utils/page-utils.ts

@@ -209,7 +209,7 @@ export async function testExportDropdown(page: Page, fileNames: string[], app: A
   });
 
   await test.step('should have "BDBag" as a download option and download the file.', async () => {
-    // test.skip(!!process.env.CI, 'in CI the export server component is not configured and cannot be tested');
+    test.skip(!!process.env.CI, 'in CI the export server component is not configured and cannot be tested');
 
     await ExportLocators.getExportDropdown(page).click();
 
@@ -226,7 +226,7 @@ export async function testExportDropdown(page: Page, fileNames: string[], app: A
   // NOTE: this is specific to the tests done in record/presentation.spec.ts and recordset/presentation.spec.ts
   if (fileNames.length > 2) {
     await test.step('should have "Configurations" option that opens a submenu to download the config file.', async () => {
-      // test.skip(!!process.env.CI, 'in CI the export server component is not configured and cannot be tested');
+      test.skip(!!process.env.CI, 'in CI the export server component is not configured and cannot be tested');
 
       await ExportLocators.getExportDropdown(page).click();