Skip to content

Commit

Permalink
Bump @playwright/test from 1.43.1 to 1.46 (#2498) + fix minor issues
Browse files Browse the repository at this point in the history
- Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.43.1 to 1.46.
- Remove the deprecated babel class plugin
- Fix minor issues in the code
  - React doesn't like using spread with key prop
  - Change the file-field tooltip to be the same as before (tooltip
     local test cases were broken because of this)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aref Shafaei <[email protected]>
  • Loading branch information
dependabot[bot] and RFSH authored Aug 7, 2024
1 parent 787be06 commit a59e4f6
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 46 deletions.
7 changes: 6 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,22 @@ updates:
interval: "monthly"
open-pull-requests-limit: 10
ignore:
- dependency-name: "@playwright/test"
- dependency-name: "moment*"
- dependency-name: "protractor"
- dependency-name: "@typescript-eslint/*"
- dependency-name: "eslint-*"
- dependency-name: "eslint"
- dependency-name: "@playwright/test"
- dependency-name: "prettier"
- dependency-name: "patch-package"
- dependency-name: "uglify-js"
groups:
babel:
patterns:
- "@babel/*"
- "babel-loader"
- "css-loader"
- "sass-loader"
bootstrap:
patterns:
- "react-bootstrap"
Expand Down
4 changes: 1 addition & 3 deletions babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,5 @@ module.exports = {
}],
'@babel/preset-typescript',
],
'plugins': [
'@babel/plugin-proposal-class-properties',
]
'plugins': []
}
63 changes: 25 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
},
"dependencies": {
"@babel/core": "7.24.x",
"@babel/plugin-proposal-class-properties": "^7.14.5",
"@babel/preset-env": "7.24.x",
"@babel/preset-react": "^7.14.5",
"@babel/preset-typescript": "7.24.x",
Expand Down
2 changes: 1 addition & 1 deletion src/components/input-switch/date-field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const DateField = (props: DateFieldProps): JSX.Element => {
* converting a strored "Date" object to string (what user sees)
* and vice versa.
*/
format={(date) => windowRef.moment(date).format(dataFormats.date)}
format={(date: any) => windowRef.moment(date).format(dataFormats.date)}
parse={(str) => windowRef.moment(str, dataFormats.date)}
autofix={false}
/**
Expand Down
2 changes: 1 addition & 1 deletion src/components/input-switch/file-field.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ const FileField = (props: FileFieldProps): JSX.Element => {
return () => {
if (fieldValue && isStringAndNotEmpty(fieldValue.filename)) {
if (fieldValue.filesize) {
return `- ${fieldValue.filename} \n- size: ${humanFileSize(fieldValue.filesize)}`;
return `- ${fieldValue.filename}\n- ${humanFileSize(fieldValue.filesize)}`;
} else {
return fieldValue.filename;
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const ChaiseTooltip = ({
* adding the tooltip as key will make sure we're remounting when tooltip changes.
* we have to remount so the tooltip position is updated properly
*/
{...(dynamicTooltipString && typeof tooltip === 'string' && { key: tooltip })}
key={dynamicTooltipString && typeof tooltip === 'string' ? tooltip : undefined}
>
{tooltip}
</Tooltip>
Expand Down

0 comments on commit a59e4f6

Please sign in to comment.