fixed anonymous fetching of favorites (don't fetch them) (#2115)

informatics-isi-edu · Aug 21, 2021 · 552da9b · 552da9b
1 parent 6816fa4
commit 552da9b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/common/faceting.js b/common/faceting.js
@@ -1220,7 +1220,7 @@
                         var table = scope.reference.table;
                         // if the stable key is greater than length 1, the favorites won't be supported for now
                         // TODO: support this for composite stable keys
-                        if (table.favoritesPath && scope.facetColumn.isEntityMode && table.stableKey.length == 1) {
+                        if (scope.$root.session && table.favoritesPath && scope.facetColumn.isEntityMode && table.stableKey.length == 1) {
                             // array of column names that represent the stable key of leaf with favorites
                             // favorites_* will use stable key to store this information
                             // NOTE: hardcode `scope.reference.table.name` for use in pure and binary table mapping

diff --git a/common/table.js b/common/table.js
@@ -2332,7 +2332,7 @@
                     var table = scope.vm.reference.table;
                     // if the stable key is greater than length 1, the favorites won't be supported for now
                     // TODO: support this for composite stable keys
-                    if (table.favoritesPath && table.stableKey.length == 1) {
+                    if (scope.$root.session && table.favoritesPath && table.stableKey.length == 1) {
                         // array of column names that represent the stable key of leaf with favorites
                         // favorites_* will use stable key to store this information
                         // NOTE: hardcode `scope.reference.table.name` for use in pure and binary table mapping
@@ -2367,6 +2367,8 @@
                         }).catch(function (error) {
                             defer.resolve({page: page});
                         });
+                    } else {
+                        defer.resolve({page: page});
                     }
 
                     return defer.promise;