Skip to content

Commit

Permalink
Bump @playwright/test from 1.48.2 to 1.49.0 (#2586)
Browse files Browse the repository at this point in the history
* Bump @playwright/test from 1.48.2 to 1.49.0

Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.48.2 to 1.49.0.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.48.2...v1.49.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* use the new chromium headless mode

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aref Shafaei <[email protected]>
  • Loading branch information
dependabot[bot] and RFSH authored Dec 3, 2024
1 parent bf0d4dc commit 302f006
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 18 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ ALL_MANUAL_TESTS=$(Manualrecordset)
define make_test
rc=0; \
for file in $(1); do \
npx playwright test --project=chrome $(2) --config $$file || rc=1; \
npx playwright test --project=chromium $(2) --config $$file || rc=1; \
done; \
exit $$rc;
endef
Expand Down Expand Up @@ -400,10 +400,11 @@ npm-install-modules:

# install packages needed for production and development (including testing)
# --include=dev makes sure to ignore NODE_ENV and install everything
# --no-shell: https://github.com/microsoft/playwright/issues/33566
.PHONY: npm-install-all-modules
npm-install-all-modules:
@npm clean-install --include=dev
@npx playwright install --with-deps
@npx playwright install --with-deps --no-shell

# for test cases we have to make sure we're installing dev dependencies and playwright is installed
.PHONY: deps-test
Expand Down
28 changes: 15 additions & 13 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 15 additions & 2 deletions test/e2e/setup/playwright.configuration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,28 @@ const getConfig = (options: TestOptions) => {
{
name: PW_PROJECT_NAMES.PRETEST,
testDir: __dirname,
testMatch: 'playwright.pretest.ts'
testMatch: 'playwright.pretest.ts',
use: {
/**
* To reduce the download size, I've added "no-shell" to the npm-install-all-modules make target.
* so only the new headless mode is available and that's why we need to define the channel.
*
* Once we decided to run the test cases on all browsers, we should see if defining this channel
* causes any issues or not. If it does, we should remove this property from here and "no-shell" from make target.
*
* https://github.com/microsoft/playwright/issues/33566
*/
channel: 'chromium',
}
},
{
name: PW_PROJECT_NAMES.CHROME,
dependencies: [PW_PROJECT_NAMES.PRETEST],
use: {
...devices['Desktop Chrome'],
...extraBrowserParams,
permissions: ['clipboard-read', 'clipboard-write']
permissions: ['clipboard-read', 'clipboard-write'],
channel: 'chromium', // https://github.com/microsoft/playwright/issues/33566
},
},
// {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/utils/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const ENTITIES_PATH = 'entities.json';

export enum PW_PROJECT_NAMES {
PRETEST = 'pretest',
CHROME = 'chrome',
CHROME = 'chromium',
FIREFOX = 'firefox',
SAFARI = 'safari'
}

0 comments on commit 302f006

Please sign in to comment.