Skip to content

Commit

Permalink
use typescript-eslint version 7 to lower the required nodejs requirement
Browse files Browse the repository at this point in the history
typescript-eslint version 8 requires node 20.9 which is pretty new,
so I downgraded the version so we can use any 20.x version.
  • Loading branch information
RFSH committed Aug 2, 2024
1 parent fe66ace commit 1da3d46
Show file tree
Hide file tree
Showing 3 changed files with 64 additions and 59 deletions.
2 changes: 2 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ module.exports = {
'@typescript-eslint/no-unsafe-function-type': 'warn',
'@typescript-eslint/ban-ts-comment': 'warn',
'@typescript-eslint/no-inferrable-types': 'warn',
// TODO we should remove the following deprecated rule when we go to version 8:
'@typescript-eslint/ban-types': 'warn',

// ------------------ testing ------------------
'@typescript-eslint/no-floating-promises': 'warn'
Expand Down
117 changes: 60 additions & 57 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
"devDependencies": {
"@isrd-isi-edu/ermrest-data-utils": "^0.0.6",
"@playwright/test": "latest",
"@typescript-eslint/eslint-plugin": "~8.0.0",
"@typescript-eslint/parser": "~8.0.0",
"@typescript-eslint/eslint-plugin": "~7.18.0",
"@typescript-eslint/parser": "~7.18.0",
"chance": "x",
"eslint": "8.57.0",
"eslint-plugin-import": "^2.25.4",
Expand Down

0 comments on commit 1da3d46

Please sign in to comment.