New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tendermint): Fix deserialization from `serde_json::Value` #1475

Open

oblique wants to merge 1 commit into informalsystems:main from oblique:fix/issue-1474

oblique commented Nov 18, 2024

Fixes #1474

Referenced an issue explaining the need for the change
Updated all relevant documentation in docs
Updated all code comments where relevant
Wrote tests
Added entry in .changelog/


          fix(tendermint): Fix deserialization from serde_json::Value

d91263f

Author

oblique commented Nov 18, 2024 •

edited

Loading

Some questions:

CowStr can also be used in any place of tendermint-rs that uses String::deserialize etc. Should I change all of them?
Do you like CowStr or should I just use String?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet