Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR-011: Validator Crate #1142

Merged
merged 2 commits into from
Jun 15, 2022
Merged

ADR-011: Validator Crate #1142

merged 2 commits into from
Jun 15, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jun 10, 2022

a proposed follow-up after
#1137
is merged.
ref: #1134

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@tomtau
ADR-011: Validator Crate
c411a86 
a proposed follow-up after
informalsystems#1137
is merged.
ref: informalsystems#1134
@tomtau tomtau mentioned this pull request Jun 13, 2022
Merged
5 tasks
thanethomson
thanethomson previously approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great idea to me @tomtau 👍

docs/architecture/adr-011-validator-crate.md Outdated Show resolved Hide resolved
@tomtau tomtau requested a review from thanethomson June 15, 2022 01:12
@thanethomson thanethomson merged commit 42a5767 into informalsystems:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomtau @thanethomson