Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.24.0 pre.2 #1124

Merged
merged 3 commits into from
May 5, 2022
Merged

Release v0.24.0 pre.2 #1124

merged 3 commits into from
May 5, 2022

Conversation

thanethomson
Copy link
Contributor

Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1124 (f8f7c22) into master (7a8d681) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1124   +/-   ##
======================================
  Coverage    64.7%   64.7%           
======================================
  Files         231     231           
  Lines       15637   15637           
======================================
  Hits        10118   10118           
  Misses       5519    5519           
Impacted Files Coverage Δ
light-client/src/lib.rs 100.0% <ø> (ø)
proto/src/lib.rs 100.0% <ø> (ø)
tendermint/src/lib.rs 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8d681...f8f7c22. Read the comment docs.

@thanethomson thanethomson merged commit ebde4a2 into master May 5, 2022
@thanethomson thanethomson deleted the release/v0.24.0-pre.2 branch May 5, 2022 12:15
@hdevalence
Copy link
Collaborator

hdevalence commented May 6, 2022

The breaking change to prost is unfortunate, since it's no longer possible to use 0.24.x with any of the other ecosystem crates (e.g., ibc-rs, which hasn't been updated yet ), or with our crates, which use a different version of prost, and were depending on 0.24.0-pre.1, the only published version that includes ABCI support.

@thanethomson
Copy link
Contributor Author

@hdevalence I'm not sure I understand. Is there something that you need from v0.24.0-pre.2 that doesn't involve the prost upgrade?

Also, the current released version(s) of ibc-rs depend on the v0.23.x series of tendermint-rs.

ibc-rs currently targets Tendermint Core v0.34.x, and the tendermint-rs v0.24.x series targets Tendermint Core v0.35.x.

Are you patching ibc-rs while using this pre-release version of tendermint-rs v0.24.x?

@thanethomson
Copy link
Contributor Author

I've logged #1127 to clarify and track what's happening with the v0.24.x series of tendermint-rs at present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants