Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade atlas-patch to support response code customization #171

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

ylongca
Copy link

@ylongca ylongca commented Jun 26, 2024

atlas-gentool 21.13 is needed to support array-type response body.
We also need support for response code customization,
which is not available in atlas-openapiv2-patch v1.0.0.

This PR is to bring atlas-openapiv2-patch v1.0.1 into the branch v21-14
to support response code customization

@rvinfoblox
Copy link

I have no context on this change. Can you please add to description of this PR more details as to why you need this change @ylongca .

@ylongca ylongca requested review from Calebjh and removed request for Calebjh June 26, 2024 18:09
@rvinfoblox
Copy link

@ylongca
Since atlas-gentool is used by many repos which may have issue with the atlas-openapiv2-patch v1.0.1 that has custom response codes, please sync with the atlas team if it is okay to bring that version of patch into the gentool in master.

If not, I suggest that you fork a branch off master of gentool, bring the patch 1.0.1 into that branch and label the build in that that branch as a specific version that can be used by your repo alone.

Also, please check why this PR build has failed.

@ylongca
Copy link
Author

ylongca commented Jun 27, 2024

@ylongca Since atlas-gentool is used by many repos which may have issue with the atlas-openapiv2-patch v1.0.1 that has custom response codes, please sync with the atlas team if it is okay to bring that version of patch into the gentool in master.

If not, I suggest that you fork a branch off master of gentool, bring the patch 1.0.1 into that branch and label the build in that that branch as a specific version that can be used by your repo alone.

Also, please check why this PR build has failed.

The build failed at the check-out code step. I don't see any log messages on why check-out code failed.

When I ran make test locally, the test passed.

I will create a branch, and base the PR on that branch.

@ylongca ylongca changed the base branch from master to v21-14 June 27, 2024 20:29
@ylongca ylongca requested a review from davidhankins June 27, 2024 21:35
@ylongca ylongca merged commit b70d224 into infobloxopen:v21-14 Jun 28, 2024
1 check passed
@ylongca ylongca deleted the upgrade-atlas-patch branch June 28, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants