Missing keys - notifications and rules #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @HaraldWilhelmi. This is a nice addition which I'd be happy to review and merge. However it's breaking one test at https://travis-ci.org/infertux/zeyple/builds/602835988 - could you fix it please? (For the record, this PR is somewhat related to #20). |
|
I see. To keep the commit history reasonable clean I will close this request and start from scratch. |
|
FYI you didn't need to open a new pull request. You can rebase your commits locally (e.g. with (References #67) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed a a few features to handle missing keys differently based on the recipient address.
If you like it - feel free to merge.
Best regards & thanks for sharing your script
Harald Wilhelmi