Fi 3007 - subscription validation #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add Requirement 73 to the verifies_requirements list for the test. |
karlnaden
requested changes
Oct 28, 2024
Comment on lines
64
to
73
| assert(subscription['criteria'].present?, | ||
| assert(subscription['criteria'].present? && valid_url?(subscription['criteria']), | ||
| 'The `criteria` field SHALL be populated and contain the canonical URL for the Subscription Topic.') | ||
| output subscription_topic: subscription['criteria'] |
There was a problem hiding this comment.
Looks like we no longer use output subscription_criteria anywhere, which means that:
- we can remove it
- we can move this URL check inside the subscription_verification method so that it gets run whenever subscriptions are verified. This also means you can add a test case or two to the spec test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
subscription_conformance_test.rbto test if the Provided URL in subscription.criteria is a valid URL and fail the test if it is not.Testing Guidance