Correctly add authorization header to Subscription.channel.header #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emichaud998
approved these changes
Dec 23, 2024
tstrass
requested changes
Dec 27, 2024
| @@ -77,8 +77,8 @@ def server_check_channel(subscription, access_token) | |||
| Added the Authorization header field with a Bearer token set to #{access_token} to the `header` field on the | |||
| Subscription resource in order to connect successfully with the Inferno subscription channel. | |||
| )) | |||
| subscription['header'] = [] unless subscription['header'].present? | |||
| subscription['header'].append("Authorization: Bearer #{access_token}") | |||
| subscription_channel['header'] = [] unless subscription['header'].present? | |||
There was a problem hiding this comment.
Seems like you'd need this change as well?
Suggested change
| subscription_channel['header'] = [] unless subscription['header'].present? | |
| subscription_channel['header'] = [] unless subscription_channel['header'].present? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when the Subscription Server tests tried to add a Subscription.channel.header value with a bearer token, it did so at the Subscription level instead. Now it does so correctly.
Testing Guidance
Run the Server tests agains the client tests following the instructions - see suite instructions - but removing the
"header": ["Authorization: Bearer SAMPLE_TOKEN"],row from the Workflow Subscription Resource input on the server tests. Verify that the tests run correctly and that when viewing the client test responsible for verifying the Subscription creation (1.3.01 - Client Subscription Conformance Verification) that the Subscription creation request includes that content under Subscription.channel.