Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2946: Limit Endpoint Availability Validation Input #26

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

emichaud998
Copy link
Collaborator

Summary

Add an input that allows the tester to limit the number of endpoints to check to avoid the test kit dying on Bundles with thousands of endpoints. The user can type in a number and Inferno will use it to cap the number of endpoints it attempts to make metadata requests to. If the user incorrectly types in a valid number in this input, Inferno will default it to 0.

@emichaud998 emichaud998 requested a review from arscan August 14, 2024 17:04
@emichaud998 emichaud998 self-assigned this Aug 14, 2024
@emichaud998 emichaud998 requested review from arscan and removed request for arscan August 30, 2024 18:05
@emichaud998 emichaud998 changed the base branch from main to FI-2945_Service_Base_URL_Refactor_Tests August 30, 2024 18:21
Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just cleaning up the code slightly and adding an informational message when not all urls are checked would be helpful here. Not necessarily critical though, so I'll approve and leave it up to you if you want to incorporate.

Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me!

@emichaud998 emichaud998 changed the base branch from FI-2945_Service_Base_URL_Refactor_Tests to main September 6, 2024 21:31
* Add input to allow user to select if some metadata requests can fail and still pass the test

* Fix issue with get not being protected and update endpoint availability limit description
@emichaud998 emichaud998 force-pushed the FI-2946_Input_Limit_Endpoints branch from e4f73e5 to 320e5d0 Compare September 6, 2024 22:04
@emichaud998 emichaud998 merged commit 79f382f into main Sep 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants