-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2946: Limit Endpoint Availability Validation Input #26
Conversation
lib/service_base_url_test_kit/service_base_url_validate_group.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just cleaning up the code slightly and adding an informational message when not all urls are checked would be helpful here. Not necessarily critical though, so I'll approve and leave it up to you if you want to incorporate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me!
* Add input to allow user to select if some metadata requests can fail and still pass the test * Fix issue with get not being protected and update endpoint availability limit description
e4f73e5
to
320e5d0
Compare
Summary
Add an input that allows the tester to limit the number of endpoints to check to avoid the test kit dying on Bundles with thousands of endpoints. The user can type in a number and Inferno will use it to cap the number of endpoints it attempts to make metadata requests to. If the user incorrectly types in a valid number in this input, Inferno will default it to 0.