-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3395 Fix suite describe with routes #577
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 274 275 +1
Lines 11663 11668 +5
Branches 1302 1302
=======================================
+ Hits 9831 9836 +5
Misses 1822 1822
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't move that definition out of lib/inferno.rb
? It could be something like lib/inferno/route_storage.rb
module Inferno
module RouteStorage
def ...
end
end
extend RouteStorage
end
Summary
Fix the bug where
bundle exec inferno suite describe <suite id>
command fails in test kits that mount custom routes. The bug was because the suites booter (i.e:Inferno::Application.start('suites')
) needs lib/inferno.rb loaded, and the CLI wasn't loading it. The backdraw is that this kicks off loading the rest of Inferno, but I think the CLI is fast enough that this is negligible.Testing Guidance
bundle install
bundle exec inferno suites
and pick any suite idbundle exec inferno suite describe <suite id>
and confirm it works