Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3565: Upgrade validator dockerfile to match upstream #576

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Dec 18, 2024

Summary

Upgrades the inferno-resource-validator Dockerfile to match the latest upstream changes in https://github.com/hapifhir/org.hl7.fhir.validator-wrapper v1.0.60

Specifically this adds a couple lines that enable the fhir package cache to work as a docker volume, from hapifhir/org.hl7.fhir.validator-wrapper@b006e3c

Testing Guidance

To build just this image and load it locally:

docker buildx build --platform linux/arm64 --build-arg "PROJECT_VERSION=1.0.60" --tag "infernocommunity/inferno-resource-validator:1.0.60" --tag infernocommunity/inferno-resource-validator:latest --load .

Then to map a volume, uncomment this line in the docker-compose here or in your favorite test kit:

# - ~/.fhir:/home/ktor/.fhir

There may still be some quirks to shake out but with that volume mapped, the validator service should start up and run as normal.

@dehall dehall requested a review from Jammjammjamm December 18, 2024 15:48
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (637a014) to head (645eb1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   84.22%   84.22%           
=======================================
  Files         272      272           
  Lines       11584    11584           
  Branches     1279     1279           
=======================================
  Hits         9757     9757           
  Misses       1817     1817           
  Partials       10       10           
Flag Coverage Δ
backend 92.59% <ø> (ø)
frontend 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dehall dehall merged commit c5ec6ae into main Dec 18, 2024
10 checks passed
@dehall dehall deleted the fi-3565-bump-validators branch December 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants