Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-3469: Use provided auth input options #560

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

AlyssaWang
Copy link
Collaborator

@AlyssaWang AlyssaWang commented Nov 19, 2024

Summary

Options for the auth selector were previously hardcoded. This change will pull options from the provided input instead.

Testing Guidance

Pull this branch into authinfo-flex to test

@AlyssaWang AlyssaWang marked this pull request as draft November 19, 2024 18:04
@AlyssaWang AlyssaWang changed the title Draft: FI-3469: Use provided auth input options FI-3469: Use provided auth input options Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (af1e650) to head (cfa5d7d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/src/components/InputsModal/AuthTypeSelector.tsx 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   84.06%   84.05%   -0.02%     
==========================================
  Files         262      262              
  Lines       11410    11409       -1     
  Branches     1254     1255       +1     
==========================================
- Hits         9592     9590       -2     
- Misses       1808     1809       +1     
  Partials       10       10              
Flag Coverage Δ
backend 92.19% <ø> (ø)
frontend 79.31% <96.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AlyssaWang AlyssaWang marked this pull request as ready for review November 19, 2024 18:35
@AlyssaWang AlyssaWang merged commit 050f4e8 into main Nov 20, 2024
10 checks passed
@AlyssaWang AlyssaWang deleted the FI-3469-auth-options branch November 20, 2024 17:45
@Shaumik-Ashraf Shaumik-Ashraf mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants