Fix npm install that fails due to wrong checksum in package-lock. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 214 214
Lines 10708 10708
Branches 991 991
=======================================
Hits 8246 8246
Misses 1884 1884
Partials 578 578
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlyssaWang
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were getting CI test failures on #375 after merging
mainback into that branch on thenpm istep regarding an invalid checksum on a downloaded npm package. I investigated to make sure nobody was tampering with npm packages (that would be very bad) somehow. Go tomainand runnpm iand you'll get:Turns out we've had an issue in the
mainbranch since #369 where the semver dependency wasn't properly updated somehow to include the right checksum for integrity checks.I verified that the checksum in there is for v6.3.0, even though we are now on v7.5.3.
I do not know why this wasn't picked up earlier by GitHub's build step on PRs. Though @360dgries had noticed it in July, but at the time others couldn't replicate it and I think we may have chalked it up to his unique Windows setup?
Testing Guidance
Prior to this,
npm iwill cause an ERR. After this,npm iwill not.