Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2198 Markdown processing added to group level #399

Merged
merged 8 commits into from
Oct 3, 2023

Conversation

360dgries
Copy link
Contributor

@360dgries 360dgries commented Oct 2, 2023

Completion of FI-2198

Added remarkGfm to the TestGroupCard so that tables can be used in descriptions for groups.

Example table added to group 1 in Demonstration Suite

@360dgries 360dgries requested a review from AlyssaWang October 2, 2023 15:36
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7927af2) 76.97% compared to head (2939c12) 76.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   76.97%   76.97%   -0.01%     
==========================================
  Files         214      214              
  Lines       10690    10693       +3     
  Branches      986      986              
==========================================
+ Hits         8229     8231       +2     
- Misses       1883     1884       +1     
  Partials      578      578              
Flag Coverage Δ
backend 94.33% <ø> (ø)
frontend 69.75% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dev_suites/dev_demo_ig_stu1/groups/demo_group.rb 94.11% <ø> (ø)
...nents/TestSuite/TestSuiteDetails/TestGroupCard.tsx 69.66% <50.00%> (-0.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jammjammjamm
Copy link
Collaborator

With GFM, you should check that it doesn't interpret any canonical url (e.g. http://hl7.org/fhir/ValueSet/my-valueset|0.8) as a table. My understanding is that the leading and trailing pipes on each line are optional.

@360dgries
Copy link
Contributor Author

With GFM, you should check that it doesn't interpret any canonical url (e.g. http://hl7.org/fhir/ValueSet/my-valueset|0.8) as a table. My understanding is that the leading and trailing pipes on each line are optional.

Thanks for the heads up. Added one, seems to be working fine:

image

@Jammjammjamm
Copy link
Collaborator

Another thing to think about: is there a reason that we don't consistently use GFM everywhere we use markdown?

Also, please add the ticket number to the PR title.

@360dgries 360dgries changed the title Markdown processing added to group level FI-2198 Markdown processing added to group level Oct 2, 2023
@AlyssaWang
Copy link
Collaborator

We probably should use GFM in all our markdown but this PR should be merged sooner rather than later so approving. @360dgries Can you make a ticket to add reactGfm to all the other places ReactMarkdown is used in inferno-core?

@360dgries 360dgries merged commit 426ab2c into main Oct 3, 2023
9 of 10 checks passed
@360dgries 360dgries deleted the FI-2198-markdown-at-group-level branch October 3, 2023 13:58
@rpassas rpassas mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants