-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
endpoint update: /validate to /$validate #48
base: main
Are you sure you want to change the base?
Conversation
According to the validate operation definition the URL should be of the form Also, I didn't mention this before, but I think we should add this new route alongside the existing route to ease our upgrade client upgrade path (i.e. we could merge this without needing a complementary inferno-core upgrade). Otherwise if we merge this and push a new dockerhub image and deploy inferno-core would break because it's not using the new route. Side Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adjust the output of the tests? Currently it prints to STANDARD_OUT
, while the other tests in the repo return a value of PASSED
, SKIPPED
, or FAILED
. Let's get it to match the rest of the repo. It's worth looking at the Github actions failures messages to see what I'm talking about (the red X marks at the bottom of the PR conversation tab).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase against main?
No description provided.